From aef2ecd51df9cb43a783ae02af0be8452e731976 Mon Sep 17 00:00:00 2001 From: m-kovalsky Date: Wed, 16 Jun 2021 09:40:38 +0300 Subject: [PATCH 1/7] Update README.md --- BestPracticeRules/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BestPracticeRules/README.md b/BestPracticeRules/README.md index fc68e4e..fec1ec7 100644 --- a/BestPracticeRules/README.md +++ b/BestPracticeRules/README.md @@ -6,6 +6,8 @@ And, check out the new [PowerBI.com blog post on v1.1](https://powerbi.microsoft Also, check out this [post](https://www.elegantbi.com/post/bestpracticerulesavings "Best Practice Rule Savings") for quantifying the savings of following specific Best Practice Rules. +Lastly, check out this video for an in-depth walkthrough of the Best Practice Rules and [Tabular Editor](https://tabulareditor.com/ "Tabular Editor")'s [Best Practice Analyzer](https://docs.tabulareditor.com/Best-Practice-Analyzer.html "Best Practice Analyzer"). + ## Purpose Running this collection of rules inside [Tabular Editor](https://tabulareditor.com/ "Tabular Editor")'s [Best Practice Analyzer](https://docs.tabulareditor.com/Best-Practice-Analyzer.html "Best Practice Analyzer") will inform you of potential issues to fix or improvements to be made with regard to performance optimization and model design. From cd1ec58fd824d5f5423dd59c83ebd7b3e5bfa484 Mon Sep 17 00:00:00 2001 From: m-kovalsky Date: Wed, 16 Jun 2021 09:41:10 +0300 Subject: [PATCH 2/7] Update README.md --- BestPracticeRules/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BestPracticeRules/README.md b/BestPracticeRules/README.md index fec1ec7..c81c9f7 100644 --- a/BestPracticeRules/README.md +++ b/BestPracticeRules/README.md @@ -6,7 +6,7 @@ And, check out the new [PowerBI.com blog post on v1.1](https://powerbi.microsoft Also, check out this [post](https://www.elegantbi.com/post/bestpracticerulesavings "Best Practice Rule Savings") for quantifying the savings of following specific Best Practice Rules. -Lastly, check out this video for an in-depth walkthrough of the Best Practice Rules and [Tabular Editor](https://tabulareditor.com/ "Tabular Editor")'s [Best Practice Analyzer](https://docs.tabulareditor.com/Best-Practice-Analyzer.html "Best Practice Analyzer"). +Lastly, check out this [video](https://www.youtube.com/watch?v=5pu9FoTUpys "video") for an in-depth walkthrough of the Best Practice Rules and [Tabular Editor](https://tabulareditor.com/ "Tabular Editor")'s [Best Practice Analyzer](https://docs.tabulareditor.com/Best-Practice-Analyzer.html "Best Practice Analyzer"). ## Purpose From 12dd889889036e230a1d019f6db2ab85f8b9f85f Mon Sep 17 00:00:00 2001 From: m-kovalsky Date: Wed, 16 Jun 2021 09:41:40 +0300 Subject: [PATCH 3/7] Update README.md --- BestPracticeRules/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BestPracticeRules/README.md b/BestPracticeRules/README.md index c81c9f7..8a492f7 100644 --- a/BestPracticeRules/README.md +++ b/BestPracticeRules/README.md @@ -6,7 +6,7 @@ And, check out the new [PowerBI.com blog post on v1.1](https://powerbi.microsoft Also, check out this [post](https://www.elegantbi.com/post/bestpracticerulesavings "Best Practice Rule Savings") for quantifying the savings of following specific Best Practice Rules. -Lastly, check out this [video](https://www.youtube.com/watch?v=5pu9FoTUpys "video") for an in-depth walkthrough of the Best Practice Rules and [Tabular Editor](https://tabulareditor.com/ "Tabular Editor")'s [Best Practice Analyzer](https://docs.tabulareditor.com/Best-Practice-Analyzer.html "Best Practice Analyzer"). +Lastly, check out this [video](https://www.youtube.com/watch?v=5pu9FoTUpys) for an in-depth walkthrough of the Best Practice Rules and [Tabular Editor](https://tabulareditor.com/ "Tabular Editor")'s [Best Practice Analyzer](https://docs.tabulareditor.com/Best-Practice-Analyzer.html "Best Practice Analyzer"). ## Purpose From 2f3f00dd1a83aa617b7570eed363ec130785e4d5 Mon Sep 17 00:00:00 2001 From: m-kovalsky Date: Thu, 17 Jun 2021 10:06:06 +0300 Subject: [PATCH 4/7] Update README.md --- BestPracticeRules/README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/BestPracticeRules/README.md b/BestPracticeRules/README.md index 8a492f7..7a81944 100644 --- a/BestPracticeRules/README.md +++ b/BestPracticeRules/README.md @@ -27,12 +27,19 @@ Following these steps will automatically load the Best Practice Rules into your 3. Run the following code in the Advanced Scripting window. ```C# +using System.Windows.Forms; System.Net.WebClient w = new System.Net.WebClient(); string path = System.Environment.GetFolderPath(System.Environment.SpecialFolder.LocalApplicationData); string url = "https://raw.githubusercontent.com/microsoft/Analysis-Services/master/BestPracticeRules/BPARules.json"; +string version = Application.ProductVersion.Substring(0,1); string downloadLoc = path+@"\TabularEditor\BPARules.json"; +if (version == "3") +{ + downloadLoc = path+@"\TabularEditor3\BPARules.json"; +} + w.DownloadFile(url, downloadLoc); ``` From 6b05a47e44e2e5dbb7c1e3d7c790992110a30346 Mon Sep 17 00:00:00 2001 From: m-kovalsky Date: Thu, 17 Jun 2021 10:09:00 +0300 Subject: [PATCH 5/7] Update README.md --- BestPracticeRules/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BestPracticeRules/README.md b/BestPracticeRules/README.md index 7a81944..076d9c0 100644 --- a/BestPracticeRules/README.md +++ b/BestPracticeRules/README.md @@ -52,8 +52,8 @@ w.DownloadFile(url, downloadLoc); 1. Download the BPARules.json file from GitHub (in this repository). 2. Within the Start Menu, type %localappdata% and click Enter. -3. Navigate to the 'TabularEditor' folder. -4. Copy the rules file (.json) and paste it into the TabularEditor folder.* +3. Navigate to the 'TabularEditor' folder (if using Tabular Editor 3, navigate to the TabularEditor3 folder). +4. Copy the rules file (.json) and paste it into the folder from Step 3.* 5. Open [Tabular Editor](https://tabulareditor.com/ "Tabular Editor") and connect to your model. 6. Select 'Tools' from the File menu and select 'Best Practice Analyzer'. 7. Click the Refresh icon (in blue). From f048e846d5aa1f096fadd76865a5d5cc0eed8714 Mon Sep 17 00:00:00 2001 From: m-kovalsky Date: Fri, 18 Jun 2021 16:26:21 +0300 Subject: [PATCH 6/7] Update README.md --- BestPracticeRules/README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/BestPracticeRules/README.md b/BestPracticeRules/README.md index 076d9c0..2334729 100644 --- a/BestPracticeRules/README.md +++ b/BestPracticeRules/README.md @@ -27,12 +27,11 @@ Following these steps will automatically load the Best Practice Rules into your 3. Run the following code in the Advanced Scripting window. ```C# -using System.Windows.Forms; System.Net.WebClient w = new System.Net.WebClient(); string path = System.Environment.GetFolderPath(System.Environment.SpecialFolder.LocalApplicationData); string url = "https://raw.githubusercontent.com/microsoft/Analysis-Services/master/BestPracticeRules/BPARules.json"; -string version = Application.ProductVersion.Substring(0,1); +string version = System.Windows.Forms.Application.ProductVersion.Substring(0,1); string downloadLoc = path+@"\TabularEditor\BPARules.json"; if (version == "3") From b754b35b87c52d572662b99ef2f2a30a4654396e Mon Sep 17 00:00:00 2001 From: m-kovalsky Date: Wed, 23 Jun 2021 09:27:40 +0300 Subject: [PATCH 7/7] Update README.md --- BestPracticeRules/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BestPracticeRules/README.md b/BestPracticeRules/README.md index 2334729..62f139c 100644 --- a/BestPracticeRules/README.md +++ b/BestPracticeRules/README.md @@ -24,7 +24,7 @@ Following these steps will automatically load the Best Practice Rules into your 1. Open [Tabular Editor](https://tabulareditor.com/ "Tabular Editor"). 2. Connect to a model. -3. Run the following code in the Advanced Scripting window. +3. Run the following code in the [Advanced Scripting](https://docs.tabulareditor.com/Advanced-Scripting.html "Advanced Scripting") window. ```C# System.Net.WebClient w = new System.Net.WebClient();